Update macro fetch code for new API#334
Merged
chennes merged 1 commit intoFreeCAD:devfrom Feb 9, 2026
Merged
Conversation
|
Successfully created backport PR for |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the AddonManager macro tooling to remain compatible with a changed catalog/git fetch API by adjusting how repository cloning/updating is invoked and improving a macro fetch warning message.
Changes:
- Update macro cache creation to call
CacheWriter.clone_or_update(...)as an instance method (matching the updated API). - Improve the warning message when macro code cannot be fetched from the wiki by including the macro name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| addonmanager_macro.py | Enhances the “unable to fetch macro code” warning to include the macro name. |
| MacroCacheCreator.py | Updates git macro retrieval to use a CacheWriter instance for clone_or_update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the API for the catalog fetch code changed, the macro code needs to be updated as well, since it uses the same clone method.