Skip to content

Update macro fetch code for new API#334

Merged
chennes merged 1 commit intoFreeCAD:devfrom
chennes:macroFixes
Feb 9, 2026
Merged

Update macro fetch code for new API#334
chennes merged 1 commit intoFreeCAD:devfrom
chennes:macroFixes

Conversation

@chennes
Copy link
Member

@chennes chennes commented Feb 9, 2026

Since the API for the catalog fetch code changed, the macro code needs to be updated as well, since it uses the same clone method.

Copilot AI review requested due to automatic review settings February 9, 2026 01:54
@chennes chennes merged commit 4541e2b into FreeCAD:dev Feb 9, 2026
15 checks passed
@chennes chennes added the release to main Trigger an Action to create a PR backporting to `main` label Feb 9, 2026
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Successfully created backport PR for main:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AddonManager macro tooling to remain compatible with a changed catalog/git fetch API by adjusting how repository cloning/updating is invoked and improving a macro fetch warning message.

Changes:

  • Update macro cache creation to call CacheWriter.clone_or_update(...) as an instance method (matching the updated API).
  • Improve the warning message when macro code cannot be fetched from the wiki by including the macro name.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
addonmanager_macro.py Enhances the “unable to fetch macro code” warning to include the macro name.
MacroCacheCreator.py Updates git macro retrieval to use a CacheWriter instance for clone_or_update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release to main Trigger an Action to create a PR backporting to `main`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant