Skip to content

Fix two asserts per linter advice#328

Merged
chennes merged 1 commit intoFreeCAD:devfrom
chennes:cleanupTest
Feb 10, 2026
Merged

Fix two asserts per linter advice#328
chennes merged 1 commit intoFreeCAD:devfrom
chennes:cleanupTest

Conversation

@chennes
Copy link
Member

@chennes chennes commented Jan 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 23, 2026 17:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses linter warnings by replacing two assertTrue(x <= y) assertions with the more specific assertLessEqual(x, y) assertions in the addon comparison test.

Changes:

  • Replaced assertTrue(same <= aa) with assertLessEqual(same, aa) on line 420
  • Replaced assertTrue(aa <= same) with assertLessEqual(aa, same) on line 421

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chennes chennes merged commit cf65ac4 into FreeCAD:dev Feb 10, 2026
11 checks passed
@chennes chennes added the release to main Trigger an Action to create a PR backporting to `main` label Feb 10, 2026
@github-actions
Copy link

Successfully created backport PR for main:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release to main Trigger an Action to create a PR backporting to `main`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant