Fixes scrolling in task #1900
Merged
Fixes scrolling in task #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/bugfix/scroll-in-task/playwright-report/index.html |
Iloveall
commented
Feb 26, 2025
| @@ -12,6 +12,7 @@ | |||
| [showTopRightControls]="!!(showTopRightControls$ | async) && !(isNarrowScreen$ | async)" | |||
| ></alg-top-bar> | |||
| <div | |||
| id="main-content-wrapper" | |||
There was a problem hiding this comment.
It's easy to broke scroll feature (for example rename the class) as we have no tool for check the build, but at least the id usually means we need it for some logic in js.
As another option we can create service for scroll and use it instead of global window variable
There was a problem hiding this comment.
We could find a way to have an automated test on that.
There was a problem hiding this comment.
I've created the task #1902
I guess with changing of new design, so almost 2 years ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1897
Notes (out of scope, known isues, hints for reviewing code, ...) (optional)
The issue is - it calls global scroll while our scroll is inside specific container
Test cases