Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes switch edit mode #1764

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

Iloveall
Copy link
Collaborator

@Iloveall Iloveall commented Aug 22, 2024

Description

Fixes #1760

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

The idea of label was to switch element on text click. After update of primeng, angular it doesn't work. As we don't use this experience in other places - I decided to remove it

Test cases

  • Case 1:

    1. Given I am the usual user
    2. When I go to this page
    3. And I click on "Edit content"
    4. Then I see content for edit
    5. And I click on "Edit content"
    6. Then I see list content
  • Case 2:

    1. Given I am the usual user
    2. When I go to this page
    3. And I click on "Edit content"
    4. Then I see list content

@Iloveall Iloveall marked this pull request as draft August 22, 2024 13:48
@smadbe
Copy link
Contributor

smadbe commented Aug 22, 2024

@Iloveall Iloveall marked this pull request as ready for review August 22, 2024 13:52
@Iloveall Iloveall requested a review from smadbe August 22, 2024 13:52
@Iloveall Iloveall force-pushed the bugfix/unable-to-leave-edit-children-mode branch from 8aa1395 to 69b368e Compare August 23, 2024 15:21
@Iloveall Iloveall merged commit 94b66ef into master Aug 23, 2024
8 of 9 checks passed
@Iloveall Iloveall deleted the bugfix/unable-to-leave-edit-children-mode branch August 23, 2024 15:28
@smadbe
Copy link
Contributor

smadbe commented Aug 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants