Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes scrollbar in top bar #1599

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

Iloveall
Copy link
Collaborator

Description

Fixes #1597

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

Tested for Windows in Sourcelab service:

Screenshot at Dec 11 17-16-43

Test cases

  • Case 1:
    1. Given I am the usual user
    2. From narrow screen (mobile)
    3. When I go to this page
    4. Then I see no changes with tabs

@Iloveall Iloveall assigned smadbe and unassigned smadbe Dec 11, 2023
@Iloveall Iloveall requested a review from smadbe December 11, 2023 15:34
@smadbe
Copy link
Contributor

smadbe commented Dec 12, 2023

On Firefox on Windows 11, I have that result: the scrollbar is displayed (while it has place to display it) and pressing the arrow does not scroll.
https://github.com/France-ioi/AlgoreaFrontend/assets/1053150/b59d6010-0371-430e-aaae-e924406791aa

Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case above needs to be fixed first.

@Iloveall Iloveall force-pushed the bugfix/tab-bar-scroll-windows-style branch from d577a23 to 791d1a4 Compare December 12, 2023 14:36
@Iloveall Iloveall requested a review from smadbe December 12, 2023 14:44
@smadbe
Copy link
Contributor

smadbe commented Dec 13, 2023

Horizontal scrollbar still displayed: (firefox on windows11)
https://github.com/France-ioi/AlgoreaFrontend/assets/1053150/6419a0f2-f4fe-4d6d-b624-4c5d87f27fb0

Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrollbar still displayed (comment above)

@Iloveall Iloveall requested a review from smadbe December 13, 2023 16:11
@smadbe
Copy link
Contributor

smadbe commented Dec 14, 2023

Much better! By any chance, is there a way to get get rid of the quick glitch of tabs at their loading?
https://github.com/France-ioi/AlgoreaFrontend/assets/1053150/c0ecd004-f1e7-4abc-9338-1b828f4b44de

Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great 🎉

@Iloveall Iloveall merged commit cbd2de6 into master Dec 15, 2023
@Iloveall Iloveall deleted the bugfix/tab-bar-scroll-windows-style branch December 15, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants