Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves design for user settings page #1588

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Improves design for user settings page #1588

merged 4 commits into from
Dec 13, 2023

Conversation

Iloveall
Copy link
Collaborator

@Iloveall Iloveall commented Dec 2, 2023 •
edited
Loading

Description

Fixes #1575

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

New tickets:
#1590
#1591

Test cases

  • Case 1:

    1. Given I am the usual user
    2. When I go to this page
    3. Then I see new tabs design
    4. And I see design changes of content

  • Case 2:

    1. Given I am the usual user
    2. When I go to this page
    3. Then I see the message "You cannot access this page for this user"

  • Case 3:

    1. Given I am the usual user
    2. When I go to this page
    3. Then I turn off network in dev panel
    4. And I click on Profile in header menu
    5. Then I see error state

@Iloveall Iloveall marked this pull request as draft December 2, 2023 16:00
@Iloveall Iloveall marked this pull request as ready for review December 4, 2023 14:08
@Iloveall Iloveall requested a review from smadbe December 4, 2023 14:08
smadbe
smadbe requested changes Dec 5, 2023
View reviewed changes
src/app/groups/containers/user/user.component.html
@@ -1,11 +1,12 @@
<ng-container *ngIf="state$ | async as state">

<alg-loading *ngIf="state.isFetching"></alg-loading>
<alg-loading class="alg-flex-1" *ngIf="state.isFetching"></alg-loading>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to work, the page is blank without loader while it is waiting.

Screen.Recording.2023-12-05.at.14.56.36.mov

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

src/app/groups/containers/platform-settings/platform-settings.component.html Outdated
</ul>
</alg-section>
</div>
<h3 class="alg-h2 alg-text-normal title" i18n>Platform settings</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is not needed anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Iloveall Iloveall force-pushed the new-design/profile-settings branch from 3ed1e83 to 33bd8da Compare December 7, 2023 14:57
@Iloveall Iloveall requested a review from smadbe December 7, 2023 15:02
smadbe
smadbe approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Iloveall Iloveall merged commit 3ff7eef into master Dec 13, 2023
@Iloveall Iloveall deleted the new-design/profile-settings branch December 13, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smadbe smadbe smadbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Design: Profile settings
2 participants
@Iloveall @smadbe