Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: Common Confirm Popup #1880

Open
5 tasks
Iloveall opened this issue Jan 24, 2025 · 0 comments
Open
5 tasks

Migration: Common Confirm Popup #1880

Iloveall opened this issue Jan 24, 2025 · 0 comments
Assignees
@Iloveall

Comments

@Iloveall
Copy link
Collaborator

Overview

There are no same type of popup (https://primeng.org/confirmpopup) component in CDK

We can replace with regular dialog

https://material.angular.io/cdk/dialog/examples

Scope: GroupManagerListComponent, JoinedGroupListComponent, MemberListComponent

Acceptance criteria

  • Remove p-confirmPopup in app component
  • Create common confirm modal component
  • Replace with service from SDK
  • Migrate styles
  • Test
@Iloveall Iloveall mentioned this issue Jan 24, 2025
Open
@Iloveall Iloveall added the to be reviewed Issue to be reviewed before starting working on it label Jan 24, 2025
@smadbe smadbe removed the to be reviewed Issue to be reviewed before starting working on it label Jan 24, 2025
@smadbe smadbe assigned Iloveall and unassigned smadbe Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Iloveall Iloveall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smadbe @Iloveall