Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from PrimeNG to angular CDK #1866

Open
Iloveall opened this issue Jan 21, 2025 · 2 comments
Open

Migration from PrimeNG to angular CDK #1866

Iloveall opened this issue Jan 21, 2025 · 2 comments
Assignees

Comments

@Iloveall
Copy link
Collaborator

Iloveall commented Jan 21, 2025

Angular Material research

Angular Material - offers a wide variety of UI components based on the Material Design specification.
Angular CDK - The Component Dev Kit (CDK) is a set of behavior primitives for building UI components.

I've installed angular material and checked - there are no style conflicts.

Current version of material theme is v2 (v18), but the next version is material v3 (v19) and they also have changed approach to the tokens system for customisation, fortunately through scss - https://material.angular.io/guide/theming#customizing-tokens

It's much better approach as we don't have to worries about future updating when the structure of html, css classes in lib will be changed (https://material.angular.io/guide/theming#direct-style-overrides), the customisation through token
does guarantee that the styles will be linked correctly. But we will have to do adjustments when migrate from v2 to v3, possible breaking changes.

New documentation for styling in v3 (19) https://material.angular.io/components/button/styling

Conclusion:

After research and attempts to customise the button I've realised - the better to use only CDK for covering behavior and our own styles.
The problem is - our design is too far from material way, their system, paddings, sizes, colours etc, ex https://m3.material.io/components/buttons/overview.

Our design is quite own, to customise material button to our style - it's set of overrides and !important flags. The tokens they provided in v3 gives oppotunity to changed
colours, hovers, state options, but not a sizes as they have strong size guide for make every components fit to each other.

PrimeNG components in app:

@Iloveall Iloveall added the to be reviewed Issue to be reviewed before starting working on it label Jan 21, 2025
@Iloveall
Copy link
Collaborator Author

Tickets by difficulty order:

#1869
#1874
#1876
#1877
#1878
#1879
#1880
#1881
#1871

Medium

#1875
#1870
#1873

For my point it will take much more time that above issues. Also still option update to v19 (after above are migrated) and fix css, as not a lot styles will left after above issues migrated

#1872
#1882
#1883

@smadbe
Copy link
Contributor

smadbe commented Jan 24, 2025

ok 👍 Globally what things are hard and has been done by others already, I am more in favor of taking the code in a custom component that we manage (and include the license if needed) than depending on external packages.

@smadbe smadbe removed the to be reviewed Issue to be reviewed before starting working on it label Jan 24, 2025
@smadbe smadbe assigned Iloveall and unassigned smadbe Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants