Open
Conversation
I tested on Laptop 13 Intel 13th gen and kblight didn't work. Signed-off-by: Daniel Schaefer <dhs@frame.work>
There was a problem hiding this comment.
Pull request overview
Fixes --kblight on certain early Framework systems by detecting whether the EC supports PwmType::KbLight and falling back to an alternative PWM mapping when it does not.
Changes:
- Added a capability probe (
has_pwmtype_kblight()) based onPwmGetDuty. - Updated
set_keyboard_backlight()to fall back toPwmType::Genericwith a different index whenKbLightisn’t supported. - Updated
get_keyboard_backlight()to use the same fallback logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+726
to
+734
| fn has_pwmtype_kblight(&self) -> bool { | ||
| // Returns EcError::Response(EcResponseStatus::InvalidParameter) on some early systems | ||
| EcRequestPwmGetDuty { | ||
| pwm_type: PwmType::KbLight as u8, | ||
| index: 0, | ||
| } | ||
| .send_command(self) | ||
| .is_ok() | ||
| } |
Comment on lines
741
to
755
| debug_assert!(percent <= 100); | ||
| let res = EcRequestPwmSetDuty { | ||
| duty: percent as u16 * (PWM_MAX_DUTY / 100), | ||
| pwm_type: PwmType::KbLight as u8, | ||
| index: 0, | ||
| let res = if self.has_pwmtype_kblight() { | ||
| EcRequestPwmSetDuty { | ||
| duty: percent as u16 * (PWM_MAX_DUTY / 100), | ||
| pwm_type: PwmType::KbLight as u8, | ||
| index: 0, | ||
| } | ||
| } else { | ||
| EcRequestPwmSetDuty { | ||
| duty: percent as u16 * (PWM_MAX_DUTY / 100), | ||
| pwm_type: PwmType::Generic as u8, | ||
| index: 1, | ||
| } | ||
| } | ||
| .send_command(self); |
Comment on lines
+749
to
+753
| EcRequestPwmSetDuty { | ||
| duty: percent as u16 * (PWM_MAX_DUTY / 100), | ||
| pwm_type: PwmType::Generic as u8, | ||
| index: 1, | ||
| } |
Comment on lines
+742
to
+750
| let res = if self.has_pwmtype_kblight() { | ||
| EcRequestPwmSetDuty { | ||
| duty: percent as u16 * (PWM_MAX_DUTY / 100), | ||
| pwm_type: PwmType::KbLight as u8, | ||
| index: 0, | ||
| } | ||
| } else { | ||
| EcRequestPwmSetDuty { | ||
| duty: percent as u16 * (PWM_MAX_DUTY / 100), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on: