turn on bay power when programming eeprom #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiram9
force-pushed
the
pr-fw16-enable-power-when-writing-eeprom
branch
from
0956338 to
71823ec
Compare
JohnAZoidberg
force-pushed
the
pr-fw16-enable-power-when-writing-eeprom
branch
from
71823ec to
89d8129
Compare
Member
|
Rebased on top of main |
Allow setting individual GPIOs. You need to be careful because the definitions can change between each platform and controlling some GPIOs can cause mainboard damaged if controlled in correctly. Co-Authored-by: Kieran Levin <[email protected]> Signed-off-by: Daniel Schaefer <[email protected]>
For fresh expansion bay modules that are unprogrammed, we need to turn on the power to program them if they are not preprogrammed with dummy values. Signed-off-by: Kieran Levin <[email protected]>
JohnAZoidberg
force-pushed
the
pr-fw16-enable-power-when-writing-eeprom
branch
from
89d8129 to
541e279
Compare
| os_specific::sleep(100_000); | ||
| if let Err(err) = res { | ||
| println!(" Failed to write chunk: {:?}", err); | ||
| return Err(err); |
Member
There was a problem hiding this comment.
Let's make this not return but break the loop, and we return the error at the end.
Then the cleanup routine at the end to disable force power still runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for fresh expansion bay modules that are unprogrammed, we need to turn on the power to program them if they are not preprogrammed with dummy values.