-
Notifications
You must be signed in to change notification settings - Fork 22
Allow encoding data with missing fields. #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Ahhh yeah, that makes sense and looks good overall! I think maybe it should be changed to Oh and maybe add a few unit tests. I'm assuming it also works with the |
In my implementation it works with |
I added a unit test; it only runs on a dedicated CSV/JSON pair because otherwise it breaks |
All the tests pass on the main branch: https://github.com/FourierTransformer/ftcsv/actions/runs/17284534932/job/49059071095. I have no intention of changing existing behaviour, and no plans for a major release, so at the moment there can't be any breaking changes to exisitn tests. You may want to look into what's causing the failures. Also, I think you may have accidentally included other new options |
Oops, I'm sorry, those were options I was experimenting with and that weren't completed. I will remove them. |
Tests pass now. Is anything else missing for approving this PR? |
This small PR allows encoding CSV from data entirely missing a field that was indicated in the
fieldsToKeep
option.Useful when encoding multiple data sets into similarly formatted CSV files.