Remove FieldDescription in Struct/ArrayMetadata in favour of DataType #3484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g31pranjal
force-pushed
the
adapt_dataType_main
branch
from
8cc9d30 to
a3fe547
Compare
arnaud-lacurie
approved these changes
Jul 15, 2025
g31pranjal
added a commit
that referenced
this pull request
Jul 17, 2025
This PR adds support for inserting structs with NULL typed fields into the table via `ExecuteInsert` in the Direct Access API. Also adds a test for the same. This bug was introduced by #3484, which essentially shifts the Relational-layer from using Sql Type codes for internal operations to relying on Relational DataTypes for getting a richer information. Fixes: #3491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically #3395 put over main, minus the UUID support. I think bringing this in as a "enhancement" separately will declutter the future UUID support PR.