Add support for UUID as primitive type in SQL #3198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g31pranjal
force-pushed
the
uuid_support
branch
from
29dbb31 to
247b596
Compare
g31pranjal
force-pushed
the
uuid_support
branch
from
ba6a83c to
dd1974d
Compare
g31pranjal
force-pushed
the
uuid_support
branch
from
83c8e5f to
3a87830
Compare
normen662
requested changes
Mar 24, 2025
...-layer-core/src/main/java/com/apple/foundationdb/record/query/plan/cascades/typing/Type.java
Outdated
Show resolved
Hide resolved
...-layer-core/src/main/java/com/apple/foundationdb/record/query/plan/cascades/typing/Type.java
Show resolved
Hide resolved
...-core/src/main/java/com/apple/foundationdb/record/query/plan/cascades/values/FieldValue.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/com/apple/foundationdb/record/query/plan/cascades/values/FieldValue.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/apple/foundationdb/record/query/plan/cascades/values/MessageHelpers.java
Show resolved
Hide resolved
fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/SqlTypeNamesSupport.java
Show resolved
Hide resolved
fdb-relational-core/src/main/java/com/apple/foundationdb/relational/api/SqlTypeSupport.java
Outdated
Show resolved
Hide resolved
normen662
requested changes
Mar 26, 2025
...-core/src/main/java/com/apple/foundationdb/record/query/plan/cascades/values/FieldValue.java
Outdated
Show resolved
Hide resolved
normen662
approved these changes
Mar 27, 2025
hatyo
reviewed
Mar 28, 2025
| final var elementField = messageDescriptor.findFieldByName(NullableArrayTypeUtils.getRepeatedFieldName()); | ||
| final var elementTypeCode = TypeCode.fromProtobufType(elementField.getType()); | ||
| return fromProtoTypeToArray(descriptor, protoType, elementTypeCode, true); | ||
| } else if (TupleFieldsProto.UUID.getDescriptor().equals(messageDescriptor)) { |
There was a problem hiding this comment.
It is a bit complex to understand why the handling of the UUID is done here and not in an outer if. But after some discussion I understand it better now. Thanks @g31pranjal for the explanation.
g31pranjal
added a commit
that referenced
this pull request
Apr 11, 2025
This PR reverts the SQL layer support for UUID that was introduced in #3198. However, the Record Layer support for UUID stays as it is. This makes this compatible with releases < `4.2.3.0` which was required to maintain plan continuation compatibility for plans serialized with non-UUID Type. Also adds a yaml-test for explicitly defining the RecordMetadata using proto, and using the `TupleField.UUID` message in it. Owing to difference in behavior in how this and versions (4.2.3.0 and 4.2.4.0) interprets `TupleField.UUID`, this PR also blocklists these versions from yaml-testing. fixes: #3285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.