Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set --warning-mode all in prb #3190

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Run Gradle Build
uses: ./actions/run-gradle
with:
gradle_command: build -x test -x destructiveTest -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport
gradle_command: build -x test -x destructiveTest -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport --warning-mode all

core-tests:
runs-on: ubuntu-latest
Expand All @@ -47,7 +47,7 @@ jobs:
uses: ./actions/gradle-test
with:
gradle_command: :fdb-record-layer-core:test :fdb-record-layer-core:destructiveTest
gradle_args: -PreleaseBuild=false -PpublishBuild=false
gradle_args: -PreleaseBuild=false -PpublishBuild=false --warning-mode all
- name: Publish Test Reports
if: always()
uses: actions/[email protected]
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
uses: ./actions/gradle-test
with:
gradle_command: test -x :fdb-record-layer-core:test destructiveTest -x :fdb-record-layer-core:destructiveTest
gradle_args: -PreleaseBuild=false -PpublishBuild=false
gradle_args: -PreleaseBuild=false -PpublishBuild=false --warning-mode all
- name: Publish Test Reports
if: always()
uses: actions/[email protected]
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
- name: Run JaCoCo Report
uses: ./actions/run-gradle
with:
gradle_command: codeCoverageReport
gradle_command: codeCoverageReport --warning-mode all
- name: Publish Coverage Report
uses: actions/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion actions/run-gradle/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ runs:
run: sed -i -e "s/^org\.gradle\..*/#&/g" gradle.properties
- name: Run Command
shell: bash
run: GRADLE_OPTS="-XX:+HeapDumpOnOutOfMemoryError -Xverify:none -XX:+TieredCompilation -Xmx4096m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED" ./gradlew --no-daemon --console=plain -b ./build.gradle ${{ inputs.gradle_command }}
run: GRADLE_OPTS="-XX:+HeapDumpOnOutOfMemoryError -XX:+TieredCompilation -Xmx4096m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED" ./gradlew --no-daemon --console=plain ${{ inputs.gradle_command }}
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ allowSnapshots=true

group=org.foundationdb

org.gradle.jvmargs=-Xmx4096m -XX:+HeapDumpOnOutOfMemoryError -Xverify:none -XX:+TieredCompilation
org.gradle.jvmargs=-Xmx4096m -XX:+HeapDumpOnOutOfMemoryError -XX:+TieredCompilation

# Set the api version used by build and CI tests. The default api version used by consumers is not impacted and is determined
# by ApiVersion.getDefault()
Expand Down
2 changes: 1 addition & 1 deletion gradle/publishing.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ if (ext.publishLibrary) {
GenerateMavenPom pomTask = tasks.generatePomFileForLibraryPublication
Jar jarTask = tasks.jar
if (filename == pomTask.destination.name) {
jarTask.archiveName.replace "jar", "pom"
jarTask.archiveFileName.map { archive -> archive.replace("jar", "pom") }
} else {
filename
}
Expand Down