-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impose runtime limits on temp table and recursive queries #2999
Draft
hatyo
wants to merge
32
commits into
FoundationDB:main
Choose a base branch
from
hatyo:recursive-cte-limits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is to be used in the TempTableInsertPlan so it can create a new TempTable in the EvaluationContext if it owns it. - recursive union plan fails because the ownership of temp tables is put incorrectly in the insert plans below (both sharing the same temp table reference which is incorrect).
- this makes testing owned temp tables much easier through dependency injection. - TempTableTests works correctly, RecursiveUnionTests fails.
- Recursive union tests pass. - State management is more complex due to divergence between initial state and recursive state transition.
- This extra state is necessary as it causes a diversion in the state transition.
- tested recursive union queries with ancestors, they give correct results with continuation. - todo: more continuation tests with descendants, this is more complex since the continuation is covering the state of more rows.
- descendants test across continuation now works.
- minor test refactoring.
- add first randomized hierarchy test. - marked as Performance for now.
Result of fdb-record-layer-pr on Linux CentOS 7
|
Result of fdb-record-layer-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.