Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impose runtime limits on temp table and recursive queries #2999

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

hatyo
Copy link
Contributor

@hatyo hatyo commented Dec 10, 2024

No description provided.

hatyo added 30 commits November 19, 2024 18:53
- this is to be used in the TempTableInsertPlan so it can create a new
  TempTable in the EvaluationContext if it owns it.
- recursive union plan fails because the ownership of temp tables is put
  incorrectly in the insert plans below (both sharing the same temp table
  reference which is incorrect).
- this makes testing owned temp tables much easier through dependency
  injection.
- TempTableTests works correctly, RecursiveUnionTests fails.
- Recursive union tests pass.
- State management is more complex due to divergence between initial
  state and recursive state transition.
- This extra state is necessary as it causes a diversion in the state transition.
- tested recursive union queries with ancestors, they give correct
  results with continuation.
- todo: more continuation tests with descendants, this is more complex
  since the continuation is covering the state of more rows.
- descendants test across continuation now works.
- minor test refactoring.
- add first randomized hierarchy test.
- marked as Performance for now.
@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: b96e503
  • Duration 0:12:51
  • Result: ❌ FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-record-layer-pr on Linux CentOS 7

  • Commit ID: 7cbf4a2
  • Duration 0:11:54
  • Result: ❌ FAILED
  • Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants