Skip to content

Commit acfc466

Browse files
committed
Adjust test and comments
1 parent 938576f commit acfc466

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

fdb-record-layer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneIndexScrubbingTest.java

+14-2
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ void luceneIndexScrubMissingDataModelNoIssues(boolean isSynthetic, boolean isGro
123123

124124
@Test
125125
void luceneIndexScrubMissingSimpleNoIssues() {
126+
// Scrub a valid index, expect zero issues
126127
Index index = SIMPLE_TEXT_SUFFIXES_WITH_PRIMARY_KEY_SEGMENT_INDEX;
127128
try (final FDBRecordContext context = openContext()) {
128129
// Write some records
@@ -157,7 +158,7 @@ void luceneIndexScrubMissingSimpleNoIssues() {
157158
@ParameterizedTest
158159
@MethodSource("threeBooleanArgs")
159160
void luceneIndexScrubMissingDataModel(boolean isSynthetic, boolean isGrouped, boolean isPartitioned) {
160-
// Scrub a valid index, expect zero issues
161+
// Scrub an index with missing entries
161162
final long seed = 207L;
162163

163164
final LuceneIndexTestDataModel dataModel = new LuceneIndexTestDataModel.Builder(seed, this::getStoreBuilderWithRegistry, pathManager)
@@ -192,8 +193,19 @@ void luceneIndexScrubMissingDataModel(boolean isSynthetic, boolean isGrouped, bo
192193
injectedFailures.setFlag(LUCENE_MAINTAINER_SKIP_INDEX_UPDATE);
193194
dataModel.saveRecords(3, 10, context, 1);
194195
dataModel.saveRecords(2, 20, context, 3);
196+
injectedFailures.setFlag(LUCENE_MAINTAINER_SKIP_INDEX_UPDATE, false);
197+
198+
dataModel.saveRecords(7, 40, context, 1);
199+
dataModel.saveRecords(7, 50, context, 2);
200+
dataModel.explicitMergeIndex(context, timer);
201+
202+
injectedFailures.setFlag(LUCENE_MAINTAINER_SKIP_INDEX_UPDATE);
195203
dataModel.saveRecords(5, 20, context, 4);
196204
injectedFailures.setFlag(LUCENE_MAINTAINER_SKIP_INDEX_UPDATE, false);
205+
206+
dataModel.saveRecords(7, 60, context, 3);
207+
208+
197209
context.commit();
198210
}
199211

@@ -239,7 +251,7 @@ void luceneIndexScrubMissingSimple() {
239251
registry.overrideFactory(new MockedLuceneIndexMaintainerFactory(injectedFailures));
240252

241253
try (final FDBRecordContext context = openContext()) {
242-
// Overwrite + add records with an injected key segment index failure
254+
// Overwrite + add records without updating the index
243255
Pair<FDBRecordStore, QueryPlanner> pair = LuceneIndexTestUtils.rebuildIndexMetaData(context, path, SIMPLE_DOC, index, isUseCascadesPlanner(), registry);
244256
this.recordStore = pair.getLeft();
245257
this.planner = pair.getRight();

0 commit comments

Comments
 (0)