Apply Scott's requested changes (Still missing - check index filter)

Author: jjezra

Diff for: fdb-record-layer-lucene/src/main/java/com/apple/foundationdb/record/lucene/LuceneIndexScrubbingToolsMissing.java

@@ -159,7 +159,7 @@ private CompletableFuture<Void> checkMissingIndexKey(FDBIndexableRecord<Message>
         }
         if (recordFields.size() == 1) {
             // A single grouping key, simple check.
-            return checkMissingIndexKey(rec, recordFields.keySet().stream().iterator().next(), issue);
+            return checkMissingIndexKey(rec, recordFields.keySet().iterator().next(), issue);
         }
 
         // Here: more than one grouping key, declare an issue if at least one of them is missing

Diff for: fdb-record-layer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneIndexScrubbingTest.java

@@ -185,13 +185,14 @@ void luceneIndexScrubMissingDataModel(boolean isSynthetic, boolean isGrouped, bo
 
         try (final FDBRecordContext context = openContext()) {
             // Write some documents
-            dataModel.saveRecords(15, 10, context, 1);
-            // Trigger failures
+            dataModel.saveRecords(7, 10, context, 1);
+            dataModel.saveRecords(7, 20, context, 2);
+            dataModel.saveRecords(7, 30, context, 3);
+            // Write few more records without updating
             injectedFailures.setFlag(LUCENE_MAINTAINER_SKIP_INDEX_UPDATE);
-            // Some overwrites (with index update failures)
-            dataModel.saveRecords(5, 10, context, 1);
-            // some new (with index update failures)
-            dataModel.saveRecords(5, 50, context, 1);
+            dataModel.saveRecords(3, 10, context, 1);
+            dataModel.saveRecords(2, 20, context, 3);
+            dataModel.saveRecords(5, 20, context, 4);
             injectedFailures.setFlag(LUCENE_MAINTAINER_SKIP_INDEX_UPDATE, false);
             context.commit();
         }