Ensure process groups are removed from the pending restart list if they are stuck in terminating or the process is missing #2325
+141
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johscheuer
commented
Jul 15, 2025
| @@ -1758,7 +1758,7 @@ var _ = Describe("Operator", Label("e2e", "pr"), func() { | |||
| fdbCluster.GetCluster().Status.ProcessGroups, | |||
| processGroupID, | |||
| ) | |||
| }).WithTimeout(5 * time.Minute).WithPolling(5 * time.Second).Should(BeNil()) | |||
| }).WithTimeout(10 * time.Minute).WithPolling(5 * time.Second).Should(BeNil()) | |||
There was a problem hiding this comment.
I increased the wait time here. In cases where the global sync mode is enabled, the coordination takes a bit longer, so the actual replacement often takes a bit longer than 5 min (from the last 2 failed tests it's often around 6min)
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
…ey are stuck in terminating or the process is missing
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
johscheuer
force-pushed
the
fixes-global-coordination
branch
from
f2b5a8b to
19b7b77
Compare
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In our e2e tests we have seen a few cases where the process groups were not removed if they are stuck in terminating. If the process is missing or stuck in terminating we should remove it from the pending restart set.
Type of change
Discussion
Testing
Ran the unit tests, CI will run the e2e tests.
Documentation
Follow-up