Support specifying backupVersion in Restore Spec #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johscheuer
reviewed
Jul 7, 2025
johscheuer
reviewed
Jul 9, 2025
There was a problem hiding this comment.
We have one backup e2e test case (https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/e2e/test_operator_backups/operator_backup_test.go), could you add a new test case for the new feature?
millasml
force-pushed
the
add-restore-versionstamp
branch
from
8bdac29 to
9f0e18e
Compare
added 2 commits
July 11, 2025 18:06
johscheuer
requested changes
Jul 16, 2025
|
@johscheuer bump on this |
johscheuer
reviewed
Jul 21, 2025
| AfterEach(func() { | ||
| backup.Stop() | ||
| log.Println("deleting backup") | ||
| factory.Delete(backup.GetBackupPod()) |
There was a problem hiding this comment.
Your current setup deletes a backup agent pod not the actual backup.
| @@ -916,8 +916,7 @@ func (client *cliAdminClient) GetBackupStatus() (*fdbv1beta2.FoundationDBLiveBac | |||
| // StartRestore starts a new restore. | |||
| func (client *cliAdminClient) StartRestore( | |||
| url string, | |||
| keyRanges []fdbv1beta2.FoundationDBKeyRange, | |||
| encryptionKeyPath string, | |||
| fdbRestoreSpec fdbv1beta2.FoundationDBRestoreSpec, | |||
There was a problem hiding this comment.
Is there a reason to pass down the spec and not the *fdbv1beta2.FoundationDBRestore? I would prefer to pass down the *fdbv1beta2.FoundationDBRestore.
There was a problem hiding this comment.
hm it's just we only need fields from the spec, I dont have any oppositions regarding passing down the entire Restore object
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support specifying backupVersion in Restore Spec. Passed into the
-voption infdbrestoreType of change
Discussion
Are there any design details that you would like to discuss further?
Testing
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
Documentation
updated docs/restore_spec.md
Follow-up
Are there any follow-up issues that we should pursue in the future?
Does this introduce new defaults that we should re-evaluate in the future?