-
Notifications
You must be signed in to change notification settings - Fork 99
Support specifying backupVersion in Restore Spec #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have one backup e2e test case (https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/e2e/test_operator_backups/operator_backup_test.go), could you add a new test case for the new feature?
8bdac29
to
9f0e18e
Compare
@johscheuer bump on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to run the e2e test cases?
AfterEach(func() { | ||
backup.Stop() | ||
log.Println("deleting backup") | ||
factory.Delete(backup.GetBackupPod()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your current setup deletes a backup agent pod not the actual backup.
@@ -916,8 +916,7 @@ func (client *cliAdminClient) GetBackupStatus() (*fdbv1beta2.FoundationDBLiveBac | |||
// StartRestore starts a new restore. | |||
func (client *cliAdminClient) StartRestore( | |||
url string, | |||
keyRanges []fdbv1beta2.FoundationDBKeyRange, | |||
encryptionKeyPath string, | |||
fdbRestoreSpec fdbv1beta2.FoundationDBRestoreSpec, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to pass down the spec and not the *fdbv1beta2.FoundationDBRestore
? I would prefer to pass down the *fdbv1beta2.FoundationDBRestore
.
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Description
Support specifying backupVersion in Restore Spec. Passed into the
-v
option infdbrestore
Type of change
Discussion
Are there any design details that you would like to discuss further?
Testing
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
Documentation
updated docs/restore_spec.md
Follow-up
Are there any follow-up issues that we should pursue in the future?
Does this introduce new defaults that we should re-evaluate in the future?