fixed Context.getSelectedDaysString Array casting to AttayList.#365
Open
tristanlifn wants to merge 1 commit into
Open
fixed Context.getSelectedDaysString Array casting to AttayList.#365tristanlifn wants to merge 1 commit into
tristanlifn wants to merge 1 commit into
Conversation
tristanlifn
added a commit
to tristanlifn/Clock
that referenced
this pull request
Jul 17, 2026
…e are more than zero groups. Removed hack fix for "getSelectedDaysString". Changed group toggle off when no alarms are on, not when all are on. changed commons version to 6.1.7 (see [PR FossifyOrg#365](FossifyOrg/commons#365))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
I am working on a feature for the clock app that utilizes the
extensions.Context.getSelectedDaysStringfunction, but i found that the type casting (on line 636) was crashing/hanging when debuging the feature. To test why, i made a hack fix, implementing said function in the file i was working in and tried to change it to a safe convertion. I have introduced this fix in this PR, it is a simple one line fix. I am not sure why this has never been a problem before, but this change should not break anything.Tests performed
This change should have no impact on performance on any device.
Checklist
CHANGELOG.md(not applicable).