Skip to content

Conversation

@aricodeine
Copy link
Contributor

@aricodeine aricodeine commented Jan 25, 2026

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Added no_sound icon to use for videos without an audio track

Tests performed

  • Tested on API 36.0 emulator

Preview

ignoreImageMinify

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh naveensingh changed the title added no_sound icon for videos without an audio track feat: add no_sound icon for videos without an audio track Jan 25, 2026
@aricodeine
Copy link
Contributor Author

aricodeine commented Jan 25, 2026

@naveensingh done with the changes, I didn't know if the new string property should be in strings.xml, can move it if needed.

@naveensingh
Copy link
Member

Looks good now, thanks!

@naveensingh naveensingh merged commit 127e836 into FossifyOrg:main Jan 26, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gray Out Audio Icon (Mute Button) When Video Contains No Sound

2 participants