Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pan/zoom simultaneous #489

Merged

Conversation

Lavesson
Copy link
Contributor

@Lavesson Lavesson commented Jan 29, 2025

Description

We had a lot of issues getting zooming/panning to work correctly, as they raced/cancelled each other. For the most part, panning took precedence, making pinch zooming almost impossible.

This changes it to be simultaneous instead. Other than that, everything should work exactly as before.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Built the library, injected it into a React Native application and manually confirmed zoom/pan worked

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • My changes generate no new warnings

Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 9553e22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 2:55pm

@bazizten
Copy link
Contributor

Ahhhhh, nice! I tried this out and it works well.

@Lavesson Lavesson changed the title Make pinch zoom simultaneous Make pan/zoom simultaneous Jan 29, 2025
@keithluchtel keithluchtel merged commit 993ee7e into FormidableLabs:main Feb 19, 2025
3 checks passed
@fmd-ci fmd-ci mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants