Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: axis labels #461

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: axis labels #461

wants to merge 9 commits into from

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Jan 3, 2025 •
edited
Loading

Description

Adds axis labels

Fixes #350

Screenshot 2025-01-03 at 1 36 37 PM Screenshot 2025-01-06 at 8 29 00 AM

Type of Change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@zibs zibs requested a review from keithluchtel January 3, 2025 22:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2e37d99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:07pm

@zibs zibs marked this pull request as ready for review January 6, 2025 16:31
keithluchtel
keithluchtel reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@keithluchtel keithluchtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does adding a label affect the xScale and yScale range? Do we need to update transformInputData at all?

example/app/dashed-axes.tsx Outdated
domain={{ y: [0, 65] }}
domainPadding={{ top: 20 }}
// domainPadding={{ top: 20 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

lib/src/cartesian/components/XAxis.tsx Outdated
})();

// Calculate vertical offset from axis
const baseOffset = fontSize * 2 + labelOffset + (yOffset ?? 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why fontSize * 2?

@zibs zibs force-pushed the feat/axis-labels branch from 3a8c86f to 2f7fdb3 Compare January 15, 2025 22:19
@zibs zibs requested a review from keithluchtel January 21, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithluchtel keithluchtel Awaiting requested review from keithluchtel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding label to x and y axis
2 participants
@zibs @keithluchtel