Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useKeyboard hook to use default argument for shouldHandleKeyboardEvents #265

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Update useKeyboard hook to use default argument for shouldHandleKeyboardEvents #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c3e7ce
update useKeyboard argument shouldHandleKeyboardEvents to default to …
JDMathew Oct 11, 2024
1a7491c
Add changesets patch bump for useKeyboard hook
JDMathew Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-planets-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@react-native-ama/extras': patch
---

Updated useKeyboard hook argument shouldHandleKeyboardEvents to default to true and not be required.
6 changes: 3 additions & 3 deletions packages/extras/src/hooks/useKeyboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,19 @@ const KEYBOARD_EVENT_HIDE: KeyboardEventName = Platform.select({
default: 'keyboardDidHide',
});

export const useKeyboard = (shouldHandleKeyboardEvents: boolean) => {
export const useKeyboard = (shouldHandleKeyboardEvents: boolean = true) => {
const keyboardHeight = useSharedValue(0);
const keyboardFinalHeight = useSharedValue(0);
const isKeyboardVisible = useSharedValue(false);

const handleKeyboardEvent = useCallback(
(
isVisible: boolean,
height: number,
endCoordinatesHeight: number,
duration: number,
easing: KeyboardEventEasing,
) => {
const finalHeight = isVisible ? height : 0;
const finalHeight = isVisible ? endCoordinatesHeight : 0;

const animationConfig = getKeyboardAnimationConfigs(easing, duration);

Expand Down
Loading