Skip to content

Conversation

@ancheetah
Copy link
Contributor

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-4284

Description

Adds helper function to get allowUserDefinedQuestions flag. Adds tests.
Added changeset

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

🦋 Changeset detected

Latest commit: 0ddd28f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@forgerock/javascript-sdk Patch
@forgerock/ping-protect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2025

View your CI Pipeline Execution ↗ for commit 0ddd28f

Command Status Duration Result
nx affected -t build lint test docs e2e-ci ✅ Succeeded 1m 14s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-21 22:28:25 UTC

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.93%. Comparing base (f9d571b) to head (0ddd28f).

Files with missing lines Patch % Lines
...t-sdk/src/fr-auth/callbacks/kba-create-callback.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #564   +/-   ##
========================================
  Coverage    56.93%   56.93%           
========================================
  Files          105      105           
  Lines        31600    31607    +7     
  Branches      1785     1785           
========================================
+ Hits         17991    17996    +5     
- Misses       13609    13611    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants