Fix pre-existing test failures in tile provider tests#33
Merged
stopflock merged 2 commits intoFoggedLens:mainfrom Feb 7, 2026
Merged
Fix pre-existing test failures in tile provider tests#33stopflock merged 2 commits intoFoggedLens:mainfrom
stopflock merged 2 commits intoFoggedLens:mainfrom
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
Fixes broken unit tests around tile providers (and removes an obsolete generated widget test) to align with current app structure / upstream API behavior.
Changes:
- Removed
test/widget_test.dartwhich referenced non-existent widgets. - Updated
DeflockTileProvidertests to use app package imports and to set upAppState.instancefor the provider logic. - Updated default tile provider tests to account for providers that require API keys being unusable by default.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/widget_test.dart | Removes obsolete generated widget smoke test. |
| test/services/deflock_tile_provider_test.dart | Updates tile provider tests to reflect new API requirements and app-state dependency. |
| test/models/tile_provider_test.dart | Fixes package import + updates usability expectations for API-key-requiring providers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- tile_provider_test: Fix stale package:flock_map_app import (now deflockapp), correct test assertion for Mapbox requiring API key - deflock_tile_provider_test: Fix relative imports, replace invalid const TileLayer with final, mock AppState.instance for getImage test - Remove widget_test.dart (default flutter create scaffold, references nonexistent MyApp counter widget) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Address PR review comments: - Add mocktail and flutter_test to dev_dependencies in pubspec.yaml - Add tearDown to reset AppState.instance between tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dougborg
force-pushed
the
pr/01-test-fixes
branch
from
9f59d34 to
73160c3
Compare
stopflock
approved these changes
Feb 7, 2026
Collaborator
stopflock
left a comment
stopflock
left a comment
There was a problem hiding this comment.
LGTM. Will have to see it in action.
Collaborator
Author
|
Yeah there shouldn't be any functional changes here from this PR. Working on the next in the series now - should have something soon with that one updated as well. |
Collaborator
|
Yep this is about as low risk as it gets. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series overview
This is the first in a series of 5 PRs that add static analysis, modernize deprecated APIs, and integrate FlockSquawk RF scanner hardware into DeFlock. The end goal is a live connection between the FlockSquawk ESP32 scanner and the DeFlock app: FlockSquawk passively detects surveillance devices via WiFi/BLE, then streams those detections to DeFlock over USB serial or BLE so users can see real-time RF alerts overlaid on the existing surveillance camera map.
The companion FlockSquawk PR series adds the firmware-side detection engine, BLE GATT server, and M5StickC UI that this app connects to.
PR stack:
Summary
Test plan
flutter testand verify all tests pass🤖 Generated with Claude Code