Use generated Dart client for deflock-router API

[dougborg]

Summary

• Replace manual JSON construction and parsing in routing_service.dart with generated types from the deflock-router OpenAPI spec
• Add deflock_router_client as a path dependency pointing to ../FlockHopper/packages/deflock_router_client

What changed in routing_service.dart

• Request building: manual Map literals → router.DirectionsRequest, router.Coordinate, router.NodeProfile with .toJson()
• Response parsing: manual data['result']['route'] map access → router.DirectionsResult.fromJson() + router.RouteGeometry fields
• Same HTTP transport, timeout handling, and error handling preserved

Dependency

Requires flockhopperdev/FlockHopper#1 to be merged first (provides the generated Dart client package).

Test plan

• flutter analyze — zero issues
• flutter test — all 41 tests pass (including 5 routing service tests)
• Request body shape unchanged (verified via test that captures serialized body)

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR migrates RoutingService to use the generated deflock_router_client OpenAPI types for request/response serialization when calling the deflock-router (alprwatch) directions endpoint, and adds the client package as a dependency.

Changes:

• Add deflock_router_client as a dependency (currently via a local path: reference).
• Replace manual request Map building with router.DirectionsRequest / router.NodeProfile serialization.
• Replace manual response map parsing with router.DirectionsResult.fromJson() and typed geometry access.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File	Description
pubspec.yaml	Adds deflock_router_client dependency via a relative path.
pubspec.lock	Records the new path dependency resolution in the lockfile.
lib/services/routing_service.dart	Uses generated request/response models instead of manual JSON maps.
COMMENT	Adds an unreferenced text/code note file.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Using a path: dependency that points outside this repository will fail in CI/release workflows (they only actions/checkout this repo, then run flutter pub get). Consider switching to a git: dependency (pinned ref/tag) or updating the GitHub Actions workflows to also checkout FlockHopper into ../FlockHopper so flutter pub get can resolve this package.

Suggested change

	path: ../FlockHopper/packages/deflock_router_client
	git:
	url: https://github.com/FlockHopper/FlockHopper.git
	path: packages/deflock_router_client
	ref: main

[Copilot]

This file appears to be an unreferenced scratch note and will ship with the app/repo unless removed. If it’s not intentionally part of the product/docs, please delete it from the PR (or move the content into an appropriate issue/PR comment).

Suggested change

	---
	An alternative approach to addressing this issue could be adjusting the `optionsBuilder` logic to avoid returning any suggestions when the input text field is empty, rather than guarding `onFieldSubmitted`. For instance:
	```dart
	optionsBuilder: (TextEditingValue textEditingValue) {
	if (textEditingValue.text.isEmpty) return <String>[];
	return suggestions.where((s) => s.contains(textEditingValue.text));
	}
	```
	This ensures that the `RawAutocomplete` widget doesn't offer any options to auto-select on submission when the field is cleared, potentially simplifying the implementation and avoiding the need for additional boolean flags (`guardOnSubmitted`). This pattern can be seen in some implementations "in the wild."

[Copilot]

pair[1] / pair[0] assumes every coordinate entry has at least 2 elements. Previously malformed pairs were filtered out; now a short/invalid pair will throw (RangeError) and get wrapped as a misleading "Network error". Add validation (e.g., length check) and throw a RoutingException with a parse/invalid response message when coordinates are missing or malformed.

Suggested change

	final waypoints = routeGeometry.coordinates.map((pair) {
	return LatLng(pair[1], pair[0]); // [lon, lat] -> LatLng(lat, lon)
	}).toList();
	final waypoints = <LatLng>[];
	for (final pair in routeGeometry.coordinates) {
	if (pair is! List || pair.length < 2) {
	throw const RoutingException(
	'Invalid routing response: coordinate pair is missing latitude/longitude');
	}
	final lon = pair[0];
	final lat = pair[1];
	if (lon is! num || lat is! num) {
	throw const RoutingException(
	'Invalid routing response: coordinate values are not numeric');
	}
	waypoints.add(LatLng(lat.toDouble(), lon.toDouble())); // [lon, lat] -> LatLng(lat, lon)
	}