Skip to content

Commit

Permalink
Fixes #17248 - Run js tests with node versions we use
Browse files Browse the repository at this point in the history
Our package builders and test infrastracture use different versions of
nodejs. We should check that all js tests pass for all different
versions used, to prevent breakage in any of our supported OSes.
  • Loading branch information
tbrisker authored and ohadlevy committed Nov 9, 2016
1 parent caffb7e commit 15cb5f8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
language: node_js
node_js:
- "node"
- "4" # Fedora
#- "0.10" # EL6, Trusty, Jessie - sadly, jest does not work with 0.10
- "4.2" # Xenial
- "4.6" # Fedora 24
- "6.9" # EL 7
before_install:
npm install -g npm@'>=3.0.0'
script: ./script/travis_run_js_tests.sh
2 changes: 1 addition & 1 deletion script/travis_run_js_tests.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -ev
if [[ $( git diff --name-only HEAD~1..HEAD webpack/ | wc -l ) -ne 0 ]]; then
if [[ $( git diff --name-only HEAD~1..HEAD webpack/ .travis.yml package.json | wc -l ) -ne 0 ]]; then
npm run test;
fi

0 comments on commit 15cb5f8

Please sign in to comment.