chore: drop redundant None default on dict.get() (ruff SIM910)#165
Open
alexzhu0 wants to merge 1 commit intoFlowElement-ai:mainfrom
Open
chore: drop redundant None default on dict.get() (ruff SIM910)#165alexzhu0 wants to merge 1 commit intoFlowElement-ai:mainfrom
alexzhu0 wants to merge 1 commit intoFlowElement-ai:mainfrom
Conversation
Ruff rule SIM910 flags `d.get(key, None)` where the default is redundant — `dict.get()` already returns `None` by default when the key is missing, so dropping the explicit `None` is byte-identical. Verification: - `uv run ruff check ... --select SIM910` is now clean - ast.parse on every touched file: clean No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ruff rule SIM910 flags
d.get(key, None)where the explicitNonedefault is redundant —dict.get()already returnsNoneby default when the key is missing. The replacement is byte-identical. 2 occurrences, both auto-fixable.Semantic equivalence
From the CPython
dict.get()docs:d.get(k)andd.get(k, None)return identically in every case. No type-hint or call-site contract shifts.Scope
2 files, 2 sites, +2 / −2.
m_flow/retrieval/episodic/bundle_search.pym_flow/retrieval/utils/fine_grained_triplet_search.pyVerification
No behavior change. Generated code under
m_flow/baml_client/is untouched.I affirm that all code in every commit of this pull request conforms to the terms of the M-flow Developer Certificate of Origin