fix(ingest): run memorize in background when run_in_background=True#161
Open
relunctance wants to merge 1 commit intoFlowElement-ai:mainfrom
Open
fix(ingest): run memorize in background when run_in_background=True#161relunctance wants to merge 1 commit intoFlowElement-ai:mainfrom
relunctance wants to merge 1 commit intoFlowElement-ai:mainfrom
Conversation
There was a problem hiding this comment.
Welcome to the M-flow project, @relunctance! 🎉
Thank you for opening this pull request. A core maintainer will review your changes shortly. In the meantime, please make sure you've read our Contributing Guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: ingest memorize async (#158)
Problem:
POST /api/v1/ingestwithrun_in_background=Truestill blocks for 30-120s because only thememorizestage ran in background;addremained sync.Root cause: The
run_in_backgroundflag was only passed tomemorize(), not applied toadd()which does the heavy LLM entity extraction + LanceDB write.Solution: When
run_in_background=True:add()synchronously (memorize needs the dataset_id from add result)memorize()asasyncio.create_task()— returnBACKGROUND_STARTEDimmediatelyThis unblocks hawk-memory's
captureDualWrite()from timing out on mFlow calls.Closes #158