Skip to content

#6199 Improve user backup detection#6202

Merged
sosnovsky merged 10 commits intomasterfrom
issue-6199-fix-improper-backup-detection
Apr 14, 2026
Merged

#6199 Improve user backup detection#6202
sosnovsky merged 10 commits intomasterfrom
issue-6199-fix-improper-backup-detection

Conversation

@martgil
Copy link
Copy Markdown
Collaborator

@martgil martgil commented Mar 27, 2026

This PR improves user's backup detection rendered in Gmail.

Closes #6199


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner March 27, 2026 10:48
@martgil martgil marked this pull request as draft March 27, 2026 10:51
@martgil
Copy link
Copy Markdown
Collaborator Author

martgil commented Mar 27, 2026

wip: adding a test

@martgil martgil marked this pull request as ready for review April 1, 2026 06:47
@martgil
Copy link
Copy Markdown
Collaborator Author

martgil commented Apr 1, 2026

Hi @sosnovsky - This one is ready for a review. Thank you!

Comment thread extension/chrome/elements/backup.ts Outdated
Comment thread extension/js/common/xss-safe-factory.ts
@martgil martgil marked this pull request as draft April 3, 2026 08:25
@martgil martgil requested a review from sosnovsky April 9, 2026 09:24
@martgil martgil marked this pull request as ready for review April 9, 2026 09:24
Comment thread extension/chrome/elements/backup.ts Outdated
Comment thread extension/chrome/elements/backup.ts Outdated
Comment thread extension/js/common/xss-safe-factory.ts
@martgil martgil requested a review from sosnovsky April 13, 2026 10:10
Copy link
Copy Markdown
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, all good now👍

@sosnovsky sosnovsky merged commit cdf6c07 into master Apr 14, 2026
12 checks passed
@sosnovsky sosnovsky deleted the issue-6199-fix-improper-backup-detection branch April 14, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improper recognition of user backup keys

2 participants