Skip to content

#5999 Add fingerprint when rendering private backups #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2025

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented May 22, 2025

This PR adds the key's fingerprint when rendering the private key backups in Gmail for easier recognition of keys, useful when removing unnecessary keys permanently.

Closes #5999

Screenshots:

For already imported keys:
loaded

For unimported keys:
unloaded


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner May 22, 2025 02:50
@martgil
Copy link
Collaborator Author

martgil commented May 22, 2025

Hi @sosnovsky, this one is ready for a review. thank you!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well 👍

@sosnovsky sosnovsky merged commit 3c0d0a5 into master May 23, 2025
12 checks passed
@sosnovsky sosnovsky deleted the issue-5999-add-fingerprint-when-rendering-backups branch May 23, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render private key fingerprint for backups
2 participants