#5983 Fix: gmail top bar overlay issue

[ioanmo226]

This PR fixed gmail top bar overlay issue

close #5983 // if this PR closes an issue

---

Tests (delete all except exactly one):

• Does not need tests (refactor only, docs or internal changes)

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[sosnovsky]

Hi @ioanmo226, I tested this PR but overlap behavior still happens on 550px window height after steps described at #5983 (comment). I also checked css code in chrome console to verify whether your style updates were applied - display: flex was present.

[ioanmo226]

Hmm.. strange
It works fine for me in both chrome and firefox.
Could you maybe rebuild & restart extension and retry?

For me, this issue only happens for small height like 350px

[sosnovsky]

I re-tested it with flowcrypt.compatibility account and your fix works well there, but top bar still overlaps on my personal account. However, I noticed that flowcrypt.compatibility has multiple send as emails configured, while my personal account has a single send as email.

So seems like when compose box includes From section for choosing send as email - fix works, but when this section is not presented - behavior is the same as before your fix. Can be some difference in css classes in compose box when From section is added.

[ioanmo226]

Aha, got it. Let me take a look.
But IMHO maybe better to leave it for future if this is too time consuming as it's not critical UI issue?

[ioanmo226]

Finished checking and this issue happens at below 380px for accounts without sendAs alias.

[ioanmo226]

Maybe something other related rather than sendAs?
My personal account without sendAs alias also seem to work fine.

[ioanmo226]

@sosnovsky Please check again and let me know, I've tried with several accounts and all work fine for me.
Maybe need to reload extension as content script is chnaged?

[sosnovsky]

@sosnovsky Please check again and let me know, I've tried with several accounts and all work fine for me. Maybe need to reload extension as content script is chnaged?

Seems like this issue is similar to #5971 - initially it occurred only on my personal email account, but later became reproducible on other accounts as well.

I tested this overlay issue using flowcrypt.compatibility account on master branch - it doesn't occur there too. So it looks like some html/css changes have been rolled out to a subset of users (including my account and those of customers who reported the issue), and later they'll be applied to other users too. That's why on your side issue seems to be fixed.

I'll check it on my side to find working solution for updated Gmail html/css code.

[ioanmo226]

Aha, I see