Skip to content

fix(auth): let non-admins authenticate to the Tooling API #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RubenHalman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(auth): let non-admins authenticate to the Tooling API #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions force-app/main/default/classes/LFSSetupController.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ public with sharing class LFSSetupController {
}

private static Flow_Scanner_OAuth_Config_Protected__mdt getConfig() {
if (!Schema.sObjectType.Flow_Scanner_OAuth_Config_Protected__mdt.fields.Consumer_Key__c.isAccessible()) {
return null;
}
// See ToolingAPI.getProductionAccessToken(): the protected custom metadata type is
// namespace-scoped, so no FLS gate is needed here. Gating on isAccessible() made
// getSetupStatus() report "not configured" to every non-admin.
List<Flow_Scanner_OAuth_Config_Protected__mdt> cfgs = [
SELECT Consumer_Key__c, Last_Updated__c
FROM Flow_Scanner_OAuth_Config_Protected__mdt
Expand Down
11 changes: 7 additions & 4 deletions force-app/main/default/classes/ToolingAPI.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,13 @@ public with sharing class ToolingAPI {

@TestVisible
private static String getProductionAccessToken() {
if (!Schema.sObjectType.Flow_Scanner_OAuth_Config_Protected__mdt.fields.Consumer_Key__c.isAccessible()) {
throw auraError('Insufficient permissions to access OAuth configuration');
}

// No FLS check here on purpose. Flow_Scanner_OAuth_Config_Protected__mdt is a
// *protected* custom metadata type, so its records are only readable by Apex inside
// this package's namespace — that namespace boundary is the security control, not
// the running user's field permissions. isAccessible() returns false for every
// non-admin subscriber user, which blocked anyone without Customize Application
// from authenticating at all. Setup actions that *write* this config stay
// admin-gated in LFSSetupController.requireAdmin().
List<Flow_Scanner_OAuth_Config_Protected__mdt> cfgs = [
SELECT Consumer_Key__c
FROM Flow_Scanner_OAuth_Config_Protected__mdt
Expand Down