Skip to content

Commit

Permalink
Move AtFwd hal from device to framework manifest.
Browse files Browse the repository at this point in the history
AtFwd hal is implemented as an android service and
it stars from system partition, that is, it's not
a traditional vendor hal and hence it should be
declared in the framework manifest and not in the
device manifest.
This commit introduces new device specific framework
manifest (framework_manifest.xml) and moves AtFwd hal
from device to framework manifest.

Bug: 68662838
Test: vts_treble_vintf_test atcmdfwd service is served

Change-Id: I9df05206fbe067ddf19a96fc52aba6b2cc922172
(cherry picked from commit b2895ddbcf1cc0b8986b4a80a43a3f0b6eb9fd66)
  • Loading branch information
Ajay Nambi authored and smore-lore committed Feb 16, 2018
1 parent 4015da3 commit 87b0264
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
1 change: 1 addition & 0 deletions BoardConfig.mk
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ BOARD_CHARGER_ENABLE_SUSPEND := true
# Vendor Interface Manifest
DEVICE_MANIFEST_FILE := device/google/wahoo/manifest.xml
DEVICE_MATRIX_FILE := device/google/wahoo/compatibility_matrix.xml
DEVICE_FRAMEWORK_MANIFEST_FILE := device/google/wahoo/framework_manifest.xml

BOARD_PROPERTY_OVERRIDES_SPLIT_ENABLED := true

Expand Down
12 changes: 12 additions & 0 deletions framework_manifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<manifest version="1.0" type="framework">
<hal format="hidl">
<name>vendor.qti.atcmdfwd</name>
<transport>hwbinder</transport>
<version>1.0</version>
<interface>
<name>IAtCmdFwd</name>
<instance>AtCmdFwdService</instance>
</interface>
</hal>
</manifest>

9 changes: 0 additions & 9 deletions manifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -465,13 +465,4 @@
<instance>cnd</instance>
</interface>
</hal>
<hal format="hidl">
<name>vendor.qti.atcmdfwd</name>
<transport>hwbinder</transport>
<version>1.0</version>
<interface>
<name>IAtCmdFwd</name>
<instance>AtCmdFwdService</instance>
</interface>
</hal>
</manifest>

0 comments on commit 87b0264

Please sign in to comment.