Merged
Conversation
fumiama
requested changes
Nov 3, 2024
Member
fumiama
left a comment
fumiama
left a comment
There was a problem hiding this comment.
model自己的私有函数可以是基础的接口，但是导出的公开函数必须是高层的抽象。牛牛的复杂玩法都要放进去，方便统一管理。
fumiama
requested changes
Nov 10, 2024
Member
fumiama
left a comment
fumiama
left a comment
There was a problem hiding this comment.
搬太多了，实际上就是一股脑全搬过来罢了，这完全不是我想要的效果。这样写不如不搬。AnimeAPI是和ZeroBot和zbpuitls解耦的，禁止增加这两个依赖。如果你能在没有这两个依赖的情况下完成这个包，那我会再仔细看你的实现。
fumiama
requested changes
Nov 26, 2024
Member
fumiama
left a comment
fumiama
left a comment
There was a problem hiding this comment.
有些问题之前就提过这次又出现，希望能举一反三。暂时这些吧，有点看不下去了。
fumiama
requested changes
Dec 11, 2024
Member
fumiama
left a comment
fumiama
left a comment
There was a problem hiding this comment.
并发地狱。。。你要两把锁，一把是数据库的，另一把是API本身的。
fumiama
approved these changes
Dec 14, 2024
fumiama
approved these changes
Dec 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.