Fixes and refactoring #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
textChange had been changed to only fire when editing ended. perhaps also need an event onEditingEnd for whoever made that change?
…tions for single line). i think a more considerable bug fix would also handle multiline also
fix and addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially clean up listener patterns and white space
I noticed a few things 'not working as expected', in which case i've been sure to change the names of the accessors.
e.g. textChange event was being fired only when editing ended (this of course should be a seperate event if you want it).
I had to make changes to stop always using ofAddListener to global events, since in my case i'm not using global listeners.
Tested with the example (had to make my own project file).
Still editing now but opening the PR to holler out