fix(Web): Dark Mode isn't friendly to find#7721
Open
cocojojo5213 wants to merge 1 commit into
Open
Conversation
|
@cocojojo5213 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Validation note: pre-commit.ci passes and I ran the focused frontend checks listed in the PR description locally. The current Vercel failures say "Authorization required to deploy", and the GitHub Actions frontend workflow is waiting for maintainer approval for this fork PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7702
Adds an always-available theme selector to the app header so users can switch theme without leaving their current page. The selector is shown in the existing desktop top nav and as a compact mobile header action.
dark_modevalue for compatibility.Review effort: 3/5
How did you test this code?
npx eslint --fix web/project/darkMode.ts web/project/darkMode.test.ts web/components/DarkModeSwitch.tsx web/components/navigation/Nav.tsx web/components/navigation/navbars/TopNavbar.tsx common/stores/account-store.jsnpm run test:unit -- --runTestsByPath web/project/darkMode.test.tsnpm run bundlegit diff --checkI also checked the touched files against
tsc; the full repository typecheck currently reports existing errors outside this change.