Skip to content

fix(Web): Dark Mode isn't friendly to find#7721

Open
cocojojo5213 wants to merge 1 commit into
Flagsmith:mainfrom
cocojojo5213:fix/visible-theme-mode-7702
Open

fix(Web): Dark Mode isn't friendly to find#7721
cocojojo5213 wants to merge 1 commit into
Flagsmith:mainfrom
cocojojo5213:fix/visible-theme-mode-7702

Conversation

@cocojojo5213
Copy link
Copy Markdown

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #7702

Adds an always-available theme selector to the app header so users can switch theme without leaving their current page. The selector is shown in the existing desktop top nav and as a compact mobile header action.

  • Adds Light, Dark, and System theme choices without using an "auto" label.
  • Keeps the account settings appearance control in sync with the header selector.
  • Updates other open tabs immediately via local storage events while preserving the legacy dark_mode value for compatibility.

Review effort: 3/5

How did you test this code?

  • npx eslint --fix web/project/darkMode.ts web/project/darkMode.test.ts web/components/DarkModeSwitch.tsx web/components/navigation/Nav.tsx web/components/navigation/navbars/TopNavbar.tsx common/stores/account-store.js
  • npm run test:unit -- --runTestsByPath web/project/darkMode.test.ts
  • npm run bundle
  • git diff --check

I also checked the touched files against tsc; the full repository typecheck currently reports existing errors outside this change.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 6, 2026

@cocojojo5213 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jun 6, 2026
@cocojojo5213 cocojojo5213 marked this pull request as ready for review June 6, 2026 18:39
@cocojojo5213 cocojojo5213 requested a review from a team as a code owner June 6, 2026 18:39
@cocojojo5213
Copy link
Copy Markdown
Author

cocojojo5213 commented Jun 6, 2026

Validation note: pre-commit.ci passes and I ran the focused frontend checks listed in the PR description locally. The current Vercel failures say "Authorization required to deploy", and the GitHub Actions frontend workflow is waiting for maintainer approval for this fork PR.

@cocojojo5213 cocojojo5213 requested review from kyle-ssg and removed request for a team June 6, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark Mode isn't friendly to find

2 participants