[Feature] inject project context into all skills and enforce constraints#703
Open
lsmonki wants to merge 1 commit intoFission-AI:mainfrom
Open
[Feature] inject project context into all skills and enforce constraints#703lsmonki wants to merge 1 commit intoFission-AI:mainfrom
lsmonki wants to merge 1 commit intoFission-AI:mainfrom
Conversation
Add `openspec instructions --context` CLI command to expose project context from config.yaml independently of any change. Update all skill templates (explore, continue, apply, ff, archive, bulk-archive, sync, verify) to load project context at session start and follow it as mandatory constraints. Strengthen enforcement language from "IMPORTANT" to "MANDATORY" for context, rules, and instruction fields across all skill and opsx command templates. Inject project context into apply instructions output via a new `context` field.
Contributor
📝 WalkthroughWalkthroughThis PR introduces a Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/core/templates/skill-templates.ts (1)
2115-2127:⚠️ Potential issue | 🟡 MinorOpsx FF command template is missing the MANDATORY guardrail block present in the FF skill template.
The FF skill template (
getFfChangeSkillTemplate, lines 767-771) includes a**MANDATORY**block reinforcing thatcontext,rules, andinstructionmust be followed and not copied. The corresponding opsx command template here omits that block, though it does have MUST language earlier (lines 2082-2090).Per the skill-context-enforcement spec (line 52-57), generated slash commands should reflect the same enforcement language as their skill templates.
Proposed fix — add MANDATORY block to opsx:ff guidelines
**Artifact Creation Guidelines** - Follow the \`instruction\` field from \`openspec instructions\` for each artifact type - The schema defines what each artifact should contain - follow it - Read dependency artifacts for context before creating new ones - Use the \`template\` as a starting point, filling in based on context +- **MANDATORY**: \`context\`, \`rules\`, and \`instruction\` from the instructions output are constraints you MUST follow + - \`context\`: Project-level constraints (tech stack, conventions) — follow them, do NOT copy into the artifact + - \`rules\`: Artifact-specific rules — follow them, do NOT copy into the artifact + - \`instruction\`: Directives for how to create this artifact — follow them + - Do NOT copy \`<context>\`, \`<rules>\`, \`<project_context>\` blocks into the artifact **Guardrails**
🧹 Nitpick comments (1)
src/commands/workflow/instructions.ts (1)
515-533: Consider extracting the shared config-reading pattern.Lines 519-524 duplicate the pattern from lines 396-401 (
readProjectConfig+ extract context + try/catch). Both could share a small helper likereadProjectContext(projectRoot): string | null. Low priority since there are only two call sites and the return types intentionally differ (nullvsundefined).
Greptile OverviewGreptile SummaryThis PR ensures all skills have access to project context from Major changes:
Implementation quality:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Agent as AI Agent/Skill
participant CLI as openspec CLI
participant Config as readProjectConfig()
participant Instructions as generateInstructions()
participant ApplyInst as generateApplyInstructions()
Note over Agent,ApplyInst: Context-only mode (Explore, Archive, Sync, etc.)
Agent->>CLI: openspec instructions --context --json
CLI->>Config: Read config.yaml
Config-->>CLI: {context: "..."}
CLI-->>Agent: {context: "..."}
Note over Agent,ApplyInst: Artifact mode (Continue, FF, New, etc.)
Agent->>CLI: openspec instructions <artifact> --change <name> --json
CLI->>Instructions: generateInstructions()
Instructions->>Config: Read config.yaml
Config-->>Instructions: {context, rules}
Instructions-->>CLI: {context, rules, template, instruction, ...}
CLI-->>Agent: Full artifact instructions
Note over Agent,ApplyInst: Apply mode (Apply, Verify)
Agent->>CLI: openspec instructions apply --change <name> --json
CLI->>ApplyInst: generateApplyInstructions()
ApplyInst->>Config: Read config.yaml (NEW)
Config-->>ApplyInst: {context}
ApplyInst-->>CLI: {context, tasks, progress, ...}
CLI-->>Agent: Apply instructions with context
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openspec instructions --contextCLI command to expose project context fromconfig.yamlindependently of any change or artifactcontextfieldcontext,rules, andinstructionfields across all skill and opsx command templatesMotivation
The
config.yamlcontextfield defines critical project constraints (tech stack, conventions, cross-platform rules), but not all skills had access to it. Explore mode, archive, bulk-archive, and sync operated without project context entirely. Other skills used softer language ("constraints for you") that agents sometimes ignored.Changes
CLI (
src/cli/index.ts,src/commands/workflow/instructions.ts)--contextflag onopenspec instructionsthat returns project context without requiring a change or artifact--change,--schema, or an artifact argument--jsonoutput for agent consumptionApply instructions (
src/commands/workflow/instructions.ts,src/commands/workflow/shared.ts)generateApplyInstructions()now reads and returns project context in thecontextfieldprintApplyInstructionsText()outputs context in a<project_context>block with AI-directed suppression commentSkill templates (
src/core/templates/skill-templates.ts)openspec instructions --context --jsonat session startinstructionfield elevated to same mandatory status ascontextandrulesDocs (
docs/cli.md)openspec instructions: artifact, apply, context-only--contextand--context --jsonTests (
test/commands/artifact-workflow.test.ts)contextInstructionsCommandwith and without config--contextflag exclusivity validationRelated issues
Summary by CodeRabbit
Release Notes
New Features
--contextflag for instructions command outputs project context from config.yaml in text or JSON formatDocumentation
Tests