Skip to content

Fix typo in example bundle.yaml #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2025
Merged

Fix typo in example bundle.yaml #289

merged 5 commits into from
Jan 30, 2025

Conversation

jhuleatt
Copy link
Collaborator

@jhuleatt jhuleatt commented Dec 26, 2024 •
edited
Loading

  • Remove second adapterVersion and replace it with frameworkVersion.
  • Remove Npm from metadata field name
  • Make runCommand a string instead of a list

jhuleatt
jhuleatt commented Dec 26, 2024
View reviewed changes
Yuangwang
Yuangwang approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@Yuangwang Yuangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Yuangwang Yuangwang merged commit 9e0287f into main Jan 30, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuangwang Yuangwang Yuangwang approved these changes

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels jamesdaniels is a code owner

@leoortizz leoortizz Awaiting requested review from leoortizz leoortizz is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhuleatt @Yuangwang