Implement two patterns us --> uk #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreypriebe
force-pushed
the
feature/more-us-to-uk-patterns
branch
from
1ddad07 to
2a3cbec
Compare
The second set added is parallel to the immediately above but is missing the 'd' on purpose (otherwise a wide number of words that shouldn't match do - e.g. 'ambassador'). Causes misses on some words (e.g. 'odor').
jeffreypriebe
force-pushed
the
feature/more-us-to-uk-patterns
branch
from
2a3cbec to
427cd67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like when two additional patterns were added in 03890d2 the reverse (US --> UK) weren't added. Added them.
Note: The second set added is parallel to the immediately above but is missing the 'd' on purpose (otherwise a wide number of words that shouldn't match do - e.g. 'ambassador').
Causes misses on some words (e.g. 'odor').