Abort sending AddName/Refresh requests when the server is shutting down #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering three names (the same host both as workstation and server, plus the workgroup name) with five retries each at two second intervals takes 30 seconds, and with more names to announce it'd only get worse. Right now, if the server is being shut down shortly after having been started, we have to wait for all those AddName requests to be processed, which seems a bit pointless.
buttercookie42
force-pushed
the
nameserver_shutdown
branch
from
856a8cc to
80ffdf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering three names (the same host both as workstation and server, plus the workgroup name) with five retries each at two second intervals takes 30 seconds, and with more names to announce it'd only get worse.
Right now, if the server is being shut down shortly after having been started, we have to wait for all those AddName requests to be processed, which seems a bit pointless.