Skip to content

Make Property cache case insensitive #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Feroks wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make Property cache case insensitive #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DynamicNotifyPropertyChanged/TypeCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ internal static class TypeCache
internal static bool TryGetObjectGetterSetter(Type type, string propertyName, out DynamicObjectGetterSetter? getterSetter)
{
getterSetter = Cache
.GetOrAdd(type, _ => new(() => new()))
.GetOrAdd(type, _ => new(() => new ConcurrentDictionary<string, Lazy<DynamicObjectGetterSetter?>>(StringComparer.OrdinalIgnoreCase)))
.Value
#if NETSTANDARD2_1
.GetOrAdd(propertyName, static (x, t) => CreateLazyGetterSetter(t, x), type)
Expand Down
13 changes: 13 additions & 0 deletions test/DynamicNotifyPropertyChanged.Tests/TypeExtensionsGetPropertyGetterShould.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,19 @@ public void ReturnCachedGetter()
.Should()
.Be(factory2);
}

[Fact]
public void BeCaseInsensitive()
{
var type = typeof(TestClass);

var factory1 = type.GetPropertyGetter(nameof(TestClass.Value));
var factory2 = type.GetPropertyGetter(nameof(TestClass.Value).ToLower());

factory1
.Should()
.Be(factory2);
}

[Fact]
public void ThrowExceptionIfPropertyNotFound()
Expand Down