Skip to content

Renamed "com.fasterxml.jackson" -> "tools.jackson" #598 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 6, 2022

Conversation

RealYusufIsmail
Copy link

Closes : #596

@RealYusufIsmail RealYusufIsmail changed the base branch from 2.14 to master November 3, 2022 15:42
@RealYusufIsmail
Copy link
Author

@cowtowncoder
Screenshot 2022-11-03 at 15 45 48

@cowtowncoder
Copy link
Member

Locally you can do mvn clean install for jackson-bom project. But I think the fix might require addition to Kotlin module pom.xml to have the "new" Maven repo: you can check jackson-databind (master branch) pom.xml for an example. Or I can do that later today.

@cowtowncoder
Copy link
Member

@RealYusufIsmail I made the addition to pom.xml in master which should fix the issue (be able to use the official Sonatype snapshot repo -- new projects (including renamed artifacts) use different repos), so you may want to merge/rebase from master.

@RealYusufIsmail
Copy link
Author

@cowtowncoder apart from 2 test failings i am done with testing, can you please review the pr for any issues

@cowtowncoder
Copy link
Member

@RealYusufIsmail Looks good but CI reports a few more failures:

Tests run: 234, Failures: 2, Errors: 13, Skipped: 6

Is it possible that some tests might be embedding fully-qualified class names?

@RealYusufIsmail
Copy link
Author

@RealYusufIsmail Looks good but CI reports a few more failures:

Tests run: 234, Failures: 2, Errors: 13, Skipped: 6

Is it possible that some tests might be embedding fully-qualified class names?

will have a look

@RealYusufIsmail
Copy link
Author

RealYusufIsmail commented Nov 4, 2022

@cowtowncoder fixed the failure

Tests run: 234, Failures: 0, Errors: 13, Skipped: 6

@RealYusufIsmail
Copy link
Author

@cowtowncoder any updates

@cowtowncoder
Copy link
Member

I'll have to get 2.14.0 release out first; will then get back to this!

@RealYusufIsmail
Copy link
Author

I'll have to get 2.14.0 release out first; will then get back to this!

np

@RealYusufIsmail
Copy link
Author

@cowtowncoder I am having an issue with testCzarSpringThing2 and testCzarSpringThing1 I keep getting the error java.lang.IndexOutOfBoundsException: Index: 1, Size: 1 and cant figure out why

ObjectMapper().readValue<Event>("""
           {"host":{"id":"host123","name":"A Czar"},"activity":"Kotlin Programming","invited":[{"id":"Guest1","name":"Mr Kotlin","rsvp": "going"}]}
        """)

this one works but

// fails with: java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
        jacksonObjectMapper().readValue<Event>("""
           {"host":{"id":"host123","name":"A Czar"},"activity":"Kotlin Programming","invited":[{"id":"Guest1","name":"Mr Kotlin","rsvp": "going"}]}
        """)

does not

@RealYusufIsmail
Copy link
Author

There is also an issue with JsonIgnore

@RealYusufIsmail
Copy link
Author

Screenshot 2022-11-06 at 10 01 17

All these issues are caused by the same thing and that is jacksonObjectMapper

@RealYusufIsmail
Copy link
Author

Other that fixed the other issues

@cowtowncoder
Copy link
Member

Thank you @RealYusufIsmail! I'll check out how many tests are failing and probably merge this; renaming itself unlikely to cause all differences.


import tools.jackson.core.json.PackageVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong! This is not the version to use here, MUST be Kotlin module's own version def.
(will fix post-merge)

@@ -41,7 +41,14 @@ class TestGithub518 {
*/
@Test
fun deserializeEmptyObjectToSingletonUnitWithSingletonSupport() {
val objectMapper = jsonMapper { addModule(kotlinModule { configure(SingletonSupport, true) }) }
val objectMapper = jsonMapper {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have preferred indentation not changed on this PR... but I guess it's what it is.

@cowtowncoder cowtowncoder merged commit 20d96c9 into FasterXML:master Nov 6, 2022
@RealYusufIsmail RealYusufIsmail deleted the rename branch November 7, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "com.fasterxml.jackson" -> "tools.jackson"
2 participants