-
-
Notifications
You must be signed in to change notification settings - Fork 177
Renamed "com.fasterxml.jackson" -> "tools.jackson" #598 #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Locally you can do |
@RealYusufIsmail I made the addition to |
@cowtowncoder apart from 2 test failings i am done with testing, can you please review the pr for any issues |
@RealYusufIsmail Looks good but CI reports a few more failures:
Is it possible that some tests might be embedding fully-qualified class names? |
will have a look |
@cowtowncoder fixed the failure
|
@cowtowncoder any updates |
I'll have to get 2.14.0 release out first; will then get back to this! |
np |
@cowtowncoder I am having an issue with testCzarSpringThing2 and testCzarSpringThing1 I keep getting the error java.lang.IndexOutOfBoundsException: Index: 1, Size: 1 and cant figure out why ObjectMapper().readValue<Event>("""
{"host":{"id":"host123","name":"A Czar"},"activity":"Kotlin Programming","invited":[{"id":"Guest1","name":"Mr Kotlin","rsvp": "going"}]}
""") this one works but // fails with: java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
jacksonObjectMapper().readValue<Event>("""
{"host":{"id":"host123","name":"A Czar"},"activity":"Kotlin Programming","invited":[{"id":"Guest1","name":"Mr Kotlin","rsvp": "going"}]}
""") does not |
There is also an issue with JsonIgnore |
Other that fixed the other issues |
Thank you @RealYusufIsmail! I'll check out how many tests are failing and probably merge this; renaming itself unlikely to cause all differences. |
|
||
import tools.jackson.core.json.PackageVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong! This is not the version to use here, MUST be Kotlin module's own version def.
(will fix post-merge)
@@ -41,7 +41,14 @@ class TestGithub518 { | |||
*/ | |||
@Test | |||
fun deserializeEmptyObjectToSingletonUnitWithSingletonSupport() { | |||
val objectMapper = jsonMapper { addModule(kotlinModule { configure(SingletonSupport, true) }) } | |||
val objectMapper = jsonMapper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have preferred indentation not changed on this PR... but I guess it's what it is.
Closes : #596