Skip to content

Rename "com.fasterxml.jackson" -> "tools.jackson" #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cowtowncoder opened this issue Oct 27, 2022 · 6 comments · Fixed by #599
Closed

Rename "com.fasterxml.jackson" -> "tools.jackson" #596

cowtowncoder opened this issue Oct 27, 2022 · 6 comments · Fixed by #599

Comments

@cowtowncoder
Copy link
Member

(see FasterXML/jackson-core#793 for background)

As the main task for JSTEP-1 (https://github.com/FasterXML/jackson-future-ideas/wiki/JSTEP-1) we need to:

  1. Change Maven package group id from "com.fasterxml.jackson.core" to "tools.jackson.core"
  2. Change Java Package name from "com.fasterxml.jackson.core" to "tools.jackson.core"

as well as all secondary changes for OSGi and Java module system.

@cowtowncoder
Copy link
Member Author

@dinomite @Spikhalskiy I did first mechanical part, and can see if I can resolve API differences. But will probably need help with repackaging of Kotlin classes themselves; it's hopefully quite mechanical. It is also likely there are some behavioral differences resulting in test failures once everything compiles again.

@RealYusufIsmail
Copy link

can i help with this

@cowtowncoder
Copy link
Member Author

@RealYusufIsmail Possibly? There are couple of compilation failures, and then the straight-forward renaming. So PR would be welcome.

@RealYusufIsmail
Copy link

will hopefully make one tomorrow

@RealYusufIsmail
Copy link

@RealYusufIsmail Possibly? There are couple of compilation failures, and then the straight-forward renaming. So PR would be welcome.

starting working on it. Created a pr #598

@cowtowncoder
Copy link
Member Author

Implemented with @RealYusufIsmail's PR -- left some test failures, probably unrelated to renaming (but formerly masked due to dependencies to older, pre-rename core Jackson 3.0.0-SNAPSHOT components):

[ERROR] Tests run: 234, Failures: 0, Errors: 9, Skipped: 6

I'll file a follow-up for solving test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants