-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support property naming strategy for Guava Ranges #57
Conversation
Ok. So, what I was thinking was to apply transformations right within But other than that I think this makes sense. |
@@ -12,6 +12,7 @@ | |||
|
|||
import com.google.common.collect.BoundType; | |||
import com.google.common.collect.Range; | |||
import java.util.Optional; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: JDK 8, can not use for Jackson 2.x
I merged unit test part (well, second of tests) in 2.10, to help verify, merge the fix. |
Thanks @cowtowncoder. I have fixed it to transform the names in |
@philleonard Looks good, I think, any tweaks I can think I can do post-merge I think. The only other thing is that I'd like to get this in 2.10, will see what'd be the best way. Just one other thing before I can merge this: if I have not yet asked for CLA (https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf), I would need that now, before the first contribution. After I receive filled one I can merge any and all contributions across projects, so it is just one time hassle. Looking forward to merging this fix, thank you again for contributing it! |
Thanks, contributor agreement has been sent your way. |
Thank you again -- I merged this, and will merge in 2.10, do some light touch up. In future it might be neat to simplify the process too, but first things first. |
Follow up PR for #56. Unsure if the public constructors are better off with a different overload structure to preserve backwards compatibility.