-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Builder pattern for creating configured Stream factories #433
Comments
Completed work for JSON package itself (commit accidentally referred to mythical issue 443, so not linked). |
So, changes include:
This has allowed making factories 100% immutable, which will then help doing the same for mapper. |
Addendum: now fully immutable all the way through, including fasterxml dataformat modules. |
After some thinking, a new 2.x release, 2.10, will include Builder-style interface too, although implementation can not guarantee full immutability like 3.0 does. The goal here is to make it easier to update 2.x code for eventual migration to 3.0; but there are also actual benefits from improved configurability. |
Yes for 3.x, |
@GedMarc Just to make sure: changes for 2.10 are included, so |
(from FasterXML/jackson3-dev#8)
Although actual mutability of
JsonFactory
(and subtypes) has not been a significant source of issues (compared toObjectMapper
), same theoretical issue exists, and ideally factories would be immutable to guarantee that users can not try to apply changes that either do not take effect, or even cause problems.Given that parser/generator features can already be defined at higher level (and passed through API with 2.x, with some improvements planned for 3.x) this is probably not a huge change for JSON factory. There may be more questions on other formats, but even there most changes can already be applied via
FormatSchema
(for CSV for example).The text was updated successfully, but these errors were encountered: