Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Builder pattern for creating configured Stream factories (nee JsonFactory) #8

Closed
cowtowncoder opened this issue Sep 12, 2017 · 2 comments

Comments

@cowtowncoder
Copy link
Member

(and make factories truly immutable)
(note: for background see #3)

Although actual mutability of JsonFactory (and subtypes) has not been a significant source of issues (compared to ObjectMapper), same theoretical issue exists, and ideally factories would be immutable to guarantee that users can not try to apply changes that either do not take effect, or even cause problems.

Given that parser/generator features can already be defined at higher level (and passed through API with 2.x, with some improvements planned for 3.x) this is probably not a huge change for JSON factory. There may be more questions on other formats, but even there most changes can already be applied via FormatSchema (for CSV for example).

@cowtowncoder
Copy link
Member Author

cowtowncoder commented Sep 12, 2017

Note: will require removal of some configuration functionality, and probably addition of some extension points. Still, not primarily considered functionality removal (although technically we will remove ability to modify instances).

@cowtowncoder
Copy link
Member Author

Started actual work, so this is now:

FasterXML/jackson-core#433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant