Skip to content

Conversation

SpacePython12
Copy link

There's a couple of classes here that were causing compilation errors because they were expecting Forge classes and interfaces, so I just put some placeholder code there so that it actually compiles.

Also, Package entities weren't being synced with the server correctly because of a missing super call (and it took me three days to figure that one out lol).

Finally, the Packager properly uses Fabric's transfer API now and doesn't void packages (or crash the game).

@SpacePython12 SpacePython12 changed the title It's like, actually functional now, yay Fixed compilation errors and problems with Packages and Packagers Jul 8, 2025
@Eggmanplant
Copy link

Eggmanplant commented Jul 8, 2025

Thanks! Check some bugs in #1772.

EDIT: Please change the version number to accommodate 6.0.6.

@SpacePython12
Copy link
Author

Thanks! Check some bugs in #1772.

EDIT: Please change the version number to accommodate 6.0.6.

Oh yeah, I saw that lol. I’ll fix it when I get the chance. I’ll also bump the version too

@SpacePython12
Copy link
Author

The rendering issues are gonna be harder to fix, it looks like an issue with Flywheel and Flywheel's documentation sucks

@Eggmanplant
Copy link

Eggmanplant commented Jul 8, 2025

The rendering issues are gonna be harder to fix, it looks like an issue with Flywheel and Flywheel's documentation sucks

EDIT: On your thing, the mixer works fine. Boxes work fine, too.

@J-eremy
Copy link

J-eremy commented Jul 8, 2025

Can confirm, Built against Java 17 and the build was successful and runs in game. Nice work @SpacePython12
image

Copy link
Member

@TropheusJ TropheusJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate it, but there's a few problems.

Please don't bump the version number. That would be incorrect without a full merge from Forge.

The rendering issues are known with a planned fix.

@SpacePython12
Copy link
Author

SpacePython12 commented Jul 13, 2025

Alright, I acknowledged your suggestions, @TropheusJ. Sorry, I'm new to the whole contributing to open source thing.

@Eggmanplant
Copy link

Eggmanplant commented Jul 13, 2025

I appreciate it, but there's a few problems.

Please don't bump the version number. That would be incorrect without a full merge from Forge.

The rendering issues are known with a planned fix.

Thanks! For some reason, IThundxr wouldn't tell me that about the graphics issues. I requested to bump the version cuz there is one commit that states: Merge v6.0.6.

EDIT: Oh, it fails to build again.

@ArifRios1st
Copy link

ArifRios1st commented Jul 19, 2025

Stock Ticker doesn't work for me. Is it just me?

Edit: i mean Category on Stock Ticker

2025-07-19.21-20-54.mp4

@J-eremy
Copy link

J-eremy commented Jul 22, 2025

Stock Ticker doesn't work for me. Is it just me?

Edit: i mean Category on Stock Ticker
2025-07-19.21-20-54.mp4

@ArifRios1st
No its not just you, the categories are broken. I have since moved over to neoforge anyway, as what I have noticed is that a lot of the mods are made for forge/neoforge and ported over to fabric as best as they can. Not so much this mod tho as the 0.5 versions work great, but getting this mod to create 6 clearly isn't a priority.

Good luck to all.

@skippyall
Copy link

I implemented fixes for the compilation errors in my PR at SpacePython12#1. My port of the vault optimisation might break other mods with modded comparators, so I don't know if it should be kept.

@skippyall
Copy link

Stock Ticker doesn't work for me. Is it just me?

Edit: i mean Category on Stock Ticker
2025-07-19.21-20-54.mp4

I didn't test it on the Forge version, but I don't think you're supposed to pull items from EMI in there. That would defeat the purpose of a category. Putting a List Filter in there works fine for me

Copy link

@ner24 ner24 Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like blockstate.onNeighborChange and blockstate.getWeakChanges are defined in IForgeBlock. Would it make sense to add default functions for these in io.github.fabricators_of_create.porting_lib.tool.extensions.BlockStateExtensions?
PS: Im brand new to this so I could be wrong

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean doing a PR for the porting lib

@ner24
Copy link

ner24 commented Aug 9, 2025

@SpacePython12 I added a PR to your fork containing essentially a 1 line code change. The rest of the compile fixes were done in Port lib: Fabricators-of-Create/Porting-Lib#179
With these I have managed to get it to compile and run

@ner24
Copy link

ner24 commented Aug 11, 2025

I am confused as to why some of these changes were implemented. Especially the ones for the packager. They seem to basically be undoing changes added in March. Are they bugged?
I was able to get it to compile with Fabricators-of-Create/Porting-Lib#179 and only these changes without issue:
image

@TropheusJ
Copy link
Member

Thanks for contributing. I've integrated all of the improvements manually.

@TropheusJ TropheusJ closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants