-
Notifications
You must be signed in to change notification settings - Fork 224
Fixed compilation errors and problems with Packages and Packagers #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed compilation errors and problems with Packages and Packagers #1785
Conversation
Thanks! Check some bugs in #1772. EDIT: Please change the version number to accommodate 6.0.6. |
Oh yeah, I saw that lol. I’ll fix it when I get the chance. I’ll also bump the version too |
The rendering issues are gonna be harder to fix, it looks like an issue with Flywheel and Flywheel's documentation sucks |
EDIT: On your thing, the mixer works fine. Boxes work fine, too. |
Can confirm, Built against Java 17 and the build was successful and runs in game. Nice work @SpacePython12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate it, but there's a few problems.
Please don't bump the version number. That would be incorrect without a full merge from Forge.
The rendering issues are known with a planned fix.
src/main/java/com/simibubi/create/content/equipment/armor/DivingHelmetItem.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/equipment/armor/RemainingAirOverlay.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/kinetics/belt/BeltBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/logistics/box/PackageEntity.java
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/logistics/vault/ItemVaultBlockEntity.java
Outdated
Show resolved
Hide resolved
Alright, I acknowledged your suggestions, @TropheusJ. Sorry, I'm new to the whole contributing to open source thing. |
Thanks! For some reason, IThundxr wouldn't tell me that about the graphics issues. I requested to bump the version cuz there is one commit that states: Merge v6.0.6. EDIT: Oh, it fails to build again. |
Stock Ticker doesn't work for me. Is it just me? Edit: i mean Category on Stock Ticker 2025-07-19.21-20-54.mp4 |
@ArifRios1st Good luck to all. |
I implemented fixes for the compilation errors in my PR at SpacePython12#1. My port of the vault optimisation might break other mods with modded comparators, so I don't know if it should be kept. |
I didn't test it on the Forge version, but I don't think you're supposed to pull items from EMI in there. That would defeat the purpose of a category. Putting a List Filter in there works fine for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like blockstate.onNeighborChange and blockstate.getWeakChanges are defined in IForgeBlock. Would it make sense to add default functions for these in io.github.fabricators_of_create.porting_lib.tool.extensions.BlockStateExtensions?
PS: Im brand new to this so I could be wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would mean doing a PR for the porting lib
@SpacePython12 I added a PR to your fork containing essentially a 1 line code change. The rest of the compile fixes were done in Port lib: Fabricators-of-Create/Porting-Lib#179 |
I am confused as to why some of these changes were implemented. Especially the ones for the packager. They seem to basically be undoing changes added in March. Are they bugged? |
Thanks for contributing. I've integrated all of the improvements manually. |
There's a couple of classes here that were causing compilation errors because they were expecting Forge classes and interfaces, so I just put some placeholder code there so that it actually compiles.
Also, Package entities weren't being synced with the server correctly because of a missing super call (and it took me three days to figure that one out lol).
Finally, the Packager properly uses Fabric's transfer API now and doesn't void packages (or crash the game).