Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various issue fixes #4031

Merged
merged 12 commits into from
Nov 6, 2024
Merged

Various issue fixes #4031

merged 12 commits into from
Nov 6, 2024

Conversation

Shnupbups
Copy link
Contributor

@Shnupbups Shnupbups commented Oct 22, 2024 •
edited
Loading

Resolves #4015
Resolves #4013
Resolves #3859
Resolves #3791
Resolves #4039
Resolves #4038
Resolves #4037
Resolves #4029

@Shnupbups Shnupbups added refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft impactful A change that is likely to affect some mods. Will require more reviews. labels Oct 22, 2024
@Shnupbups Shnupbups requested review from apple502j and a team October 22, 2024 06:03
@Shnupbups Shnupbups changed the title 1.21.2 rc2 fixes Various issue fixes Oct 22, 2024
@Shnupbups Shnupbups added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Oct 23, 2024
@github-actions github-actions bot changed the base branch from 1.21.2-rc2 to 1.21.3 October 23, 2024 14:56
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 1.21.3

@github-actions github-actions bot added release A PR that targets a release version of Minecraft and removed snapshot A PR that targets a snapshot version of Minecraft update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Oct 23, 2024
@Shnupbups Shnupbups added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 24w44a

@github-actions github-actions bot changed the base branch from 1.21.3 to 24w44a October 30, 2024 17:04
@github-actions github-actions bot added snapshot A PR that targets a snapshot version of Minecraft and removed release A PR that targets a release version of Minecraft update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Oct 30, 2024
@Shnupbups Shnupbups requested a review from haykam821 October 30, 2024 17:20
@apple502j
Copy link
Contributor

Will merge just before next snapshot.

@Shnupbups Shnupbups added the bug Fixes or discusses a bug within the mappings label Nov 6, 2024
@Shnupbups Shnupbups merged commit 614c273 into FabricMC:24w44a Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Octol1ttle Octol1ttle Octol1ttle approved these changes

@apple502j apple502j apple502j approved these changes

@haykam821 haykam821 haykam821 approved these changes

Assignees
No one assigned
Labels
bug Fixes or discusses a bug within the mappings impactful A change that is likely to affect some mods. Will require more reviews. refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
4 participants
@Shnupbups @apple502j @haykam821 @Octol1ttle